# A simplified version of a Yahtzee game

Hello y’all

I’m trying to make a simplified version of a Yahtzee game
I am stuck trying to display the frequencies of each number(1 to 6) and returning the result as an array of the Sides on the Dice in integers.

It is displaying all zeros instead of the actual dice number.

I don’t see the issue…maybe because i’ve been looking at this code too long… need a second set of eyes to double check this for me.

``````final int NUM_SIDES=6;   //Sides on the dice
final int NUM_DICE=5;    //The number of dice used
int[] rolls = new int[NUM_DICE];

void rollDice(){
for (int i=0; i < NUM_DICE; i++) {
rolls[i]=1 + int(random(NUM_SIDES));
}
}//rollDice

void showDiceRoll(){
for ( int d = 0; d < NUM_DICE; d++) {
drawDie( d, rolls[d] );
}
}//showDiceRoll

int[] freqCount(int[] roll){
int[] freqs= new int [NUM_SIDES];
for(int i=0; i<roll.length; i++){
}
return freqs;
}

int maxOfAKind(int[] freqs){
int max = Integer.MIN_VALUE;
if (freqs != null)
for (final int i : freqs)
if (i > max)  max = i;
return max; //Find and return the largest integer in an array of integers.

}//maxOfAKind

void setup(){
size(500,500);
displayMessage("Click to roll");
}//setup

void draw(){
}//draw

void mouseClicked(){
background(192);
rollDice();
showDiceRoll();
displayStats(rolls);
println(maxOfAKind(rolls));
}

void displayMessage(String message){
//Display the given message in the centre of the window.
final int TEXT_SIZE = 20;
textSize(TEXT_SIZE);
fill(0);
//Allow for multi-line messages. Count the \n characters to see.
int numLines = 1; //One by default
for(int i=0; i<message.length(); i++)
if(message.charAt(i) == '\n')
numLines++; //Add one more line for every \n character found
text(message,(width-textWidth(message))/2,
height/2-TEXT_SIZE*numLines/2);
}

void displayStats(int[] theDice){
//Test the freqCount and maxOfAKind functions by calling them
//and displaying the results as a message.
int[] freqs = freqCount(theDice);
int maxFreq = maxOfAKind(freqs);
String message = "Frequencies of 1.."+NUM_SIDES+" are:\n";
for(int i=0; i<NUM_SIDES; i++)
message += freqs[i]+"   ";
message += "\nLargest one is "+maxFreq+" of a kind.\n";
message += "Click to roll again.";
displayMessage(message);
}

void drawDie(int position, int value ){

final float X_SPACING = (float)width/NUM_DICE;       //X spacing of the dice
final float DIE_SIZE = X_SPACING*0.8;    //width and height of one die
final float X_LEFT_DIE = X_SPACING*0.1;  //left side of the leftmost die
final float Y_OFFSET = X_SPACING*0.15;   //slight Y offset of the odd-numbered ones
final float Y_POSITION = height-DIE_SIZE-Y_OFFSET; //Y coordinate of most dice
final float PIP_OFFSET = DIE_SIZE/3.5;  //Distance from centre to pips, and between pips
final float PIP_DIAM = DIE_SIZE/5;    //Diameter of the pips (dots)

//From the constants above, and which die it is, find its top left corner
float dieX = X_LEFT_DIE+position*X_SPACING;
float dieY = Y_POSITION-Y_OFFSET*(position%2);

//1.Draw a red square with a black outline
stroke(0); //Black outline
fill(255,0,0); //Red fill
rect(dieX,dieY,DIE_SIZE,DIE_SIZE);

//2.Draw the pips (dots)
fill(255);   //White dots
stroke(255); //White outline

//The centre dot (if the value is odd)
if(1 == value%2)
ellipse(dieX+DIE_SIZE/2,dieY+DIE_SIZE/2,PIP_DIAM,PIP_DIAM);

//The top-left and bottom-right dots (if the value is more than 1)
if(value>1){
ellipse(dieX+DIE_SIZE/2-PIP_OFFSET,
dieY+DIE_SIZE/2+PIP_OFFSET,PIP_DIAM,PIP_DIAM);
ellipse(dieX+DIE_SIZE/2+PIP_OFFSET,
dieY+DIE_SIZE/2-PIP_OFFSET,PIP_DIAM,PIP_DIAM);
}//if

//The bottom-left and top-right dots (if the value is more than 3)
if(value>3){
ellipse(dieX+DIE_SIZE/2+PIP_OFFSET,
dieY+DIE_SIZE/2+PIP_OFFSET,PIP_DIAM,PIP_DIAM);
ellipse(dieX+DIE_SIZE/2-PIP_OFFSET,
dieY+DIE_SIZE/2-PIP_OFFSET,PIP_DIAM,PIP_DIAM);
}//if

//The left and right dots (if the value is 6 or more)
if(value>=6){
ellipse(dieX+DIE_SIZE/2-PIP_OFFSET,
dieY+DIE_SIZE/2,PIP_DIAM,PIP_DIAM);
ellipse(dieX+DIE_SIZE/2+PIP_OFFSET,
dieY+DIE_SIZE/2,PIP_DIAM,PIP_DIAM);
}//if

//The top and bottom centre dots (if the value is 8 or more)
//Normal dice don't have these, but this function allows for
//dice with up to 9 "sides" (values from 1-9).
if(value>=8){
ellipse(dieX+DIE_SIZE/2,
dieY+DIE_SIZE/2-PIP_OFFSET,PIP_DIAM,PIP_DIAM);
ellipse(dieX+DIE_SIZE/2,
dieY+DIE_SIZE/2+PIP_OFFSET,PIP_DIAM,PIP_DIAM);
}

}
``````
1 Like

``````int[] freqCount(int[] roll){
int[] freqs= new int [NUM_SIDES];
for(int i=0; i<roll.length; i++){
}
return freqs;
}
``````

I’m not sure, but I feel like you are lacking something inside the `for` loop.
So you end up defining an `int[] freqs` array, which automatically gets filled with zeros, then doing absolutely nothing on it, and then returning that array full of zeros.
I think you wanted to do this instead:

``````int[] freqCount(int[] roll) {
int[] freqs= new int [NUM_SIDES];
for (int i=0; i<roll.length; i++) {
freqs[roll[i]-1]+=1; //Count all the rolls
}
return freqs;
}
``````
2 Likes

Thank you very much,

I’m so stupid how did I miss that there was nothing in the for loop xd