Value as a string from a void function

ok i understood what does this mean and i am doing all these above, but the problem still exists…
Please help me…