P5.js web editor doesn't like private fields

josephh · June 9, 2022, 8:57pm

Hi @fabiopettinati,

Looking at the p5-web-editor code, I found that they use CodeMirror which is a code editor written in JavaScript.

For the private fields, looks like the issue has already been solved in 2020 on their GitHub repository:

github.com/codemirror/codemirror5

Syntax highlighting not working for private fields

opened 10:07AM - 27 Apr 20 UTC

closed 09:08AM - 28 Apr 20 UTC

TimvdLippe

Private fields (https://v8.dev/features/class-fields) use a `#` at the start of …the field declaration in a class. CodeMirror currently doesn't highlight these private fields as fields and its syntax highlighting marks the whole line as red. Example ```js class Project { #id; constructor(name) { this.name = name; this.#id = Math.random(); } get id() { return this.#id; } #setId(id) { this.#id = id; } aMethod() {} static fromStore(id, name) { const proj = new Project(name); proj.#setId(id); proj.aMethod(); return proj; } } ``` Current syntax highlighting: <img width="318" alt="Screenshot 2020-04-27 at 11 01 05" src="https://user-images.githubusercontent.com/5948271/80359893-6cbc0000-8876-11ea-966b-ac0dcecffbbf.png"> (Code was pasted on https://codemirror.net/mode/javascript/index.html) The expected syntax highlighting here is that private fields have the same color as normal fields (e.g. `name` in this example). Downstream issue: https://bugs.chromium.org/p/chromium/issues/detail?id=1073903

The thing is that p5-web-editor uses codemirror ^5.62.0 which may not be up to date with the latest package.

As @mnse said, you can open an issue on the p5 editor repository.

Topic		Replies	Views
Web editor p5.js logging problem p5.js	1	235	October 1, 2020
Making a Class; web editor vs local Coding Questions	6	1106	May 9, 2019
Editor Environment Highlight for Kids Teaching	4	433	July 31, 2021
Web editor jumps around when errors occur while im writing classes p5.js	1	196	July 13, 2021
Stuck on Loading Beginners	4	3042	April 3, 2020

P5.js web editor doesn't like private fields

Related Topics