Clean up my code & retry button

ArcJAVA · October 17, 2022, 3:02pm

Hi, i need to make a game where i pick up treasure. but i have quite a lot of unnecesery or dubble code. so i was wondering if someone could help me with making my code less complicated and easier for others to copy if i send it to them. the code exits of different modules.

ps : I’m not allowed to use oop.

// module 1: App
int screens = 1;
final int BLACK = 0;
final int WHITE = 255;
final int BLUE = #FFF300;

void setup() {
  size (1200, 800);
  setupStartScreen();
  setupSpelscreen();
}

void draw() {
  drawScreens();
  switch(keyCode) {
  case DOWN:
    moveDiverDown();
    break;
  case UP:
    moveDiverUp();
    break;
  case RIGHT:
    moveDiverRight();
    break;
  case LEFT:
    moveDiverLeft();
    break;
  }
}

void mousePressed() {
  pressedOnStart();
  pressedOnRetry();
}

void drawScreens() {
  switch (screens) {
  case 1:
    {
      clear();
      drawStartScreen();
      break;
    }
  case 2:
    {
      clear();
      drawGameScreen();
      break;
    }

  case 3:
    {
      clear();
      drawEndScreen();
      break;
    }
  }
}

// module 2: end screen 

void drawEndScreen() {
  drawTitle();
  drawRetryButton();
  drawTotalAmountPoints();
}


void drawTotalAmountPoints() {
  fill(WHITE);
  textSize(20);
  text("Behaalde punten : " + points, 100, 100);
}

void drawRetryButton() {
  fill(#4DCEC4);
  rect(500, 650, 200, 100);
  fill(WHITE);
  text("RETRY", 600, 690 );
}

void pressedOnRetry() {
  if (pressedOnStart(500, 650, 200, 100, mouseX, mouseY)) {
    screens = 1;
  }
}

//module 3: game screen 

// overzicht maken
final int AIR = 255;
final int WATER = #5FAEFF;
final int TREASURE = #FFF300;
final int MINES = 0;
boolean hit = false;
int treasure;
int xBoat, yBoat, bBoat, hBoat;
int b, h;
int mines;
int points;
int lives;
int xPoints;
int xLives;
int yScorebord;
int drawDiver;
int xDiver, yDiver, bDiver;
int speed;

void setupSpelscreen() { // op juiste volgorde zetten
  b = width / 60;
  h = b;
  xDiver = b * 5;
  yDiver = b * 6;
  xBoat = 0;
  bBoat = height / 4;
  yBoat = b * 7;
  hBoat = 3 * b;
  xPoints = yDiver;
  xLives = width / 2;
  yScorebord = b + b/2;
  treasure = 5; // voor schaalbaarheid
  mines = 5; // voor schaalbaarheid
  points = 0; // vast
  lives = 3; // vast
  bDiver = b;
  speed = 3; // te verstellen

  randomizeTreasure();
}

void drawGameScreen() {
  randomizeMines();
  drawGrid(grid);
  drawBoat();
  drawScorebord();
  drawDiver();
  treasureTouched();
  minesTouched();
  stopGame();
}

void drawObjects(int x, int y, int b, int  h, int kleur) {
  fill(kleur);
  rect(x, y, b, h);
}

// dubbele code
void randomizeTreasure() {
  while (treasure > 0) {
    int i = floor(random(40));
    int j = floor(random(60));
    if (grid[i][j] == 0) {
      grid[i][j] = 2;
      treasure--;
    }
  }
}

void randomizeMines() {
  while (mines > 0) {
    int i = floor(random(40));
    int j = floor(random(60));
    if (grid[i][j] == 0) {
      grid[i][j] = 3;
      mines--;
    }
  }
}


void drawGrid(int grid [][]) {
  for (int i = 0; i < grid.length; i++) {
    for (int j = 0; j< grid[i].length; j++)
    {
      int x = j * b;
      int y = i * b;
      switch (grid[i][j]) {
      case 0:
        {
          drawObjects(x, y, b, h, WATER); 
          break;
        }
      case 1:
        {
           drawObjects(x, y, b, h, AIR);
          break;
        }
      case 2:
        {
          drawObjects(x, y, b, h, TREASURE);
          break;
        }
      case 3:
        {
          drawObjects(x, y, b, h, MINES);
          break;
        }
      }
    }
  }
}

void drawBoat () {
  fill(#11524F);
  rect(xBoat, yBoat, bBoat, hBoat);
}

void drawScorebord() {
  tekenScore();
  tekenLevens();
}


void tekenScore() {
  textSize(yScorebord);
  text("Punten: " + points, xPoints, yScorebord);
}

void tekenLevens() {
  textSize(yScorebord);
  text("levens: " + lives, xLives, yScorebord);
}

void drawDiver() {
  fill(#AAC9C7);
  square(xDiver, yDiver, bDiver);
}

boolean bodemAangeraakt = false;
boolean magNaarBoven = false;

void moveDiverDown() {
  if (yDiver < 780.5) {
    yDiver = yDiver + speed;
  } else {
    bodemAangeraakt = true;
    magNaarBoven = true;
  }
}

void moveDiverUp() {
  if (yDiver > 200 && magNaarBoven == true) {
    yDiver = yDiver - speed;
  } else {
    magNaarBoven = false;
  }
}


void moveDiverRight() {
  if (xDiver < 1200 - bDiver) {
    xDiver = xDiver +  speed;
  }
}

void moveDiverLeft() {
  if (xDiver > 0) {
    xDiver = xDiver -  speed;
  }
}

void treasureTouched() {

  for (int j = 0; j < grid.length; j++) {
    for (int k = 0; k < grid[j].length; k++) {
      if (grid[j][k] == 2) {
        int xVakje = b * k;
        int yVakje = h * j;
        if (dist(xDiver, yDiver, xVakje, yVakje) <= b) {
          grid[j][k] = 0;
          hit = true;
          drawGrid(grid);
        }
      }
    }
  }

  if (hit) {
    points = points + 50;
    hit = false;
  }
}

void minesTouched() {
  for (int j = 0; j < grid.length; j++) {
    for (int k = 0; k < grid[j].length; k++) {
      if (grid[j][k] == 3) {
        int xMine = b * k;
        int yMine = h * j;
        if (dist(xDiver, yDiver, xMine, yMine) <= b) {
          grid[j][k] = 0;
          hit = true;
          drawGrid(grid);
        }
      }
    }
  }
  if (hit) {
    lives--;
    hit = false;
  }
}

boolean goesDiverUp;

void DiverDirectionIsUp() {
  goesDiverUp = true;
}

void diverDirectionIsDown() {
  goesDiverUp = false;
}

void stopGame () {
  if (lives == 0 || points == 250 ) {
    screens = 3;
  }
}

// module 4: Start screen
int xButton;
int xTitle;
int yTitle;
int yButton;
int bButton;
int hButton;
int xText;
int yText;


void drawStartScreen() {
  background(#125498);
  drawTitle();
  drawStartButton();
}

void setupStartScreen() {
  xTitle = width / 2;
  yTitle = height / 2;
  hButton = height / 8;
  bButton = hButton * 3;
  xButton = xTitle - (bButton/2);
  yButton = bButton + (hButton * 2);
  xText = xButton + (bButton / 2);
  yText = yButton + 40;
}

void drawTitle() {
  fill(255);
  textSize(50);
  textAlign(CENTER, CENTER);
  text("Diving for treasure", xTitle, yTitle);
}

void drawStartButton() {
  fill(255);
  rect(xButton, yButton, bButton, hButton);
  fill(0);
  text("START", xText, yText);
}

void pressedOnStart() {
  if (pressedOnStart(xButton, yButton, bButton, hButton, mouseX, mouseY)) {
    screens = 2;
  }
}

boolean pressedOnStart (int xbutton, int yButton, int bButton, int hButton, int xMouse, int yMouse) {
  return xMouse > xbutton && xMouse < xbutton + bButton && yMouse > yButton && yMouse < yButton + hButton;
}

// Module 5: Grid 
int  [][] grid = {
  {1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1},
  {1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1},
  {1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1},
  {1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1},
  {1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1},
  {1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1},
  {1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1},
  {1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1},
  {1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1},
  {1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1},
  {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
  {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
  {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
  {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
  {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
  {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
  {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
  {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
  {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
  {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
  {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
  {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
  {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
  {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
  {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
  {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
  {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
  {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
  {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
  {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
  {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
  {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
  {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
  {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
  {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
  {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
  {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
  {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
  {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
  {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}
};

jafal · October 17, 2022, 3:16pm

Hi

Best way to organize code using OOP

ArcJAVA · October 17, 2022, 3:17pm

oh i forgot to mention that im not allowed to use oop

sableRaph · October 17, 2022, 3:24pm

Please use the optional “homework” tag when asking for help with assignments. Thanks!

svan · October 18, 2022, 5:27am

ArcJAVA:

void drawScreens() {
  switch (screens) {
  case 1:
    {
      clear();
      drawStartScreen();
      break;
    }
  case 2:
    {
      clear();
      drawGameScreen();
      break;
    }

  case 3:
    {
      clear();
      drawEndScreen();
      break;
    }
  }
}

I don’t think you need the brackets around each case, eg could be shortened to:

void drawScreens() {
  switch (screens) {
  case 1:
      clear();
      drawStartScreen();
      break;
  case 2:
      clear();
      drawGameScreen();
      break;
  case 3:
      clear();
      drawEndScreen();
      break;
  }
}

Sometimes the diver gets ‘stuck’ and won’t move unless you hit a certain arrow, ie some of the arrows quit working temporarily.
Retry button doesn’t work as expected; doesn’t really restart the game.
You have two functions called ‘pressedOnStart()’. One returns void and the other returns a boolean; you might not be calling the one that you think you are. One of these should probably be renamed.
You understand this game because you wrote it, but for the rest of us we don’t know what the object of the game is or how the score is calculated. What’s a good score? Perhaps a help screen which explains how the game is to be played and what the goal is.

It’s evident that you have put in a lot of time on this and are to be commended for your efforts. My advice is to keep striving to make it better. It’s like the first draft of a book; you may have to revise it several times before you get it where you want it.

Topic		Replies	Views
Treasure game: how to pick up items and end the game? Coding Questions homework	20	311	October 16, 2022
Help With My New Game Coding Questions	3	371	July 22, 2018
Processing, button, void Coding Questions	31	1746	May 20, 2019
Small help with a small draw Coding Questions	1	514	September 30, 2019
Start, Exit and other buttons: main menu -> game Coding Questions homework	1	1048	October 25, 2018

Clean up my code & retry button

Related topics