# HiScapes roast my game!

**URL:** <https://discourse.processing.org/t/hiscapes-roast-my-game/12082>\
**Category:** Gallery\
**Created:** [June 15, 2019, 3:21pm UTC](https://discourse.processing.org/t/hiscapes-roast-my-game/12082 "2019-06-15T15:21:58Z")\
**Posts on this page:** 8\
**Page:** 1

<div class="post-metadata">

**Author:** ![InferNova](https://yyz2.discourse-cdn.com/flex036/user_avatar/discourse.processing.org/infernova/32/6009_2.png) [@InferNova](https://discourse.processing.org/u/InferNova)\
**Post date:** [June 15, 2019, 3:21pm UTC](https://discourse.processing.org/t/hiscapes-roast-my-game/12082/1 "2019-06-15T15:21:58Z")

</div>

Hey guys !

I am working on a game, and I am looking for constructive criticism on how can efficiency can be increased / minimize unecessary use of resources. Things to note: This is a version that I am happy to share with you guys. Some parts of the code are missing but it runs. Please bit everything apart and tell me how it can be improved !.

Also anyone who does pose critical comments I will reply to you and keep you on a list to credit when I am finished with the game. Please roast it !

[HiScapes](https://github.com/MarcinKrzykowski/HiScapes)

P.S The game is under the **HiScapes** folder. I am so excited to hear back from you guys !

UPDATE: RELEASING MY PRIVATE REPO FOR A WHILE PLEASE ROAST IT. THE GAME IN V\_0020 IS THE CURRENT STATE OF THE GAME.

---

<div class="post-metadata">

**Author:** ![jb4x](https://yyz2.discourse-cdn.com/flex036/user_avatar/discourse.processing.org/jb4x/32/789_2.png) [@jb4x](https://discourse.processing.org/u/jb4x)\
**Post date:** [June 24, 2019, 5:07pm UTC](https://discourse.processing.org/t/hiscapes-roast-my-game/12082/2 "2019-06-24T17:07:16Z")

</div>

Hi,

I don’t really know what you game is supposed to do but right now we can’t move the player.

You need to modify your `show()` function of your `Player` class:

```auto
void show(int r, int g, int b) {
  fill(r, g, b);
  ellipseMode(CORNER);
  ellipse(pos.x, pos.y, size, size); // You had ellipse(width/2, height/2, size, size);
  update();
}

```

Also, the update part of a game loop is usually perfomed before displaying the result.

---

<div class="post-metadata">

**Author:** ![InferNova](https://yyz2.discourse-cdn.com/flex036/user_avatar/discourse.processing.org/infernova/32/6009_2.png) [@InferNova](https://discourse.processing.org/u/InferNova)\
**Post date:** [June 24, 2019, 7:05pm UTC](https://discourse.processing.org/t/hiscapes-roast-my-game/12082/3 "2019-06-24T19:05:58Z")

</div>

That the very old version ! I should have specified ! I was playing out there with stuff I am way ahead from that. For the current up to date look at the V\_0020 branch and the HiScapes folder or the V\_0015 HiScapes folder. There is the proper game to roast there !

---

<div class="post-metadata">

**Author:** ![josephh](https://yyz2.discourse-cdn.com/flex036/user_avatar/discourse.processing.org/josephh/32/210_2.png) [@josephh](https://discourse.processing.org/u/josephh)\
**Post date:** [June 24, 2019, 11:40pm UTC](https://discourse.processing.org/t/hiscapes-roast-my-game/12082/4 "2019-06-24T23:40:40Z")

</div>

> [@InferNova](#):
>
> I was playing out there with stuff I am way ahead from that.

Then you should merge your branch into the master branch on github so people can use the right version.

---

<div class="post-metadata">

**Author:** ![InferNova](https://yyz2.discourse-cdn.com/flex036/user_avatar/discourse.processing.org/infernova/32/6009_2.png) [@InferNova](https://discourse.processing.org/u/InferNova)\
**Post date:** [June 25, 2019, 11:07am UTC](https://discourse.processing.org/t/hiscapes-roast-my-game/12082/5 "2019-06-25T11:07:14Z")

</div>

All right ! The game is in the master branch in the HiScapes folder !

---

<div class="post-metadata">

**Author:** ![BennyHacker](https://yyz2.discourse-cdn.com/flex036/user_avatar/discourse.processing.org/bennyhacker/32/2969_2.png) [@BennyHacker](https://discourse.processing.org/u/BennyHacker)\
**Post date:** [June 25, 2019, 2:03pm UTC](https://discourse.processing.org/t/hiscapes-roast-my-game/12082/6 "2019-06-25T14:03:53Z")

</div>

Just a little searing

The player movement seems ‘clunky’. The only way I can think to fix this is to use 4 separate booleans (maybe a boolean[] array) and set them true on keyPressed() and false on keyReleased(). That way the combined inputs won’t interfere and you’re player will be able to move in all directions with no fail

The player speed seems quite stiff. I think experimenting with momentum wouldn’t hurt.

The “back” button in the join server menu does not work after one of the text boxes has been clicked

I’m assuming you’re only drawing tiles that are on screen, but I’m getting a framerate of about 35 when traversing the level. It was probably just my potato computer trying to draw all the tiles.

Still, I can’t help but feel the speed can be improved (maybe quad trees? or clever usage of larger and fewer tiles)

---

<div class="post-metadata">

**Author:** ![InferNova](https://yyz2.discourse-cdn.com/flex036/user_avatar/discourse.processing.org/infernova/32/6009_2.png) [@InferNova](https://discourse.processing.org/u/InferNova)\
**Post date:** [June 25, 2019, 3:20pm UTC](https://discourse.processing.org/t/hiscapes-roast-my-game/12082/7 "2019-06-25T15:20:52Z")

</div>

@Benny Hacker thank you for the lovely suggestions ! I will definitely work on adding different Tiles sizes as I also do feature FPS drop in fullScreen. And will be also interested to see what quads are !

But coming around about the Player control if we look into the gameFrame class we can see that :

```auto
 void keyPressed() {
    p1.move(keyCode, true);
  }
  void keyReleased() {
    p1.move(keyCode, false);
    p1.offLoadControls();
  }

```

Are present these in the Player class do feature 4 boolean values with a ‘switch’ statement layout. I also added as Sprites where glitching another layer of else if when the keys are **true** so you can move in different directions all the time. Maybe that causing the clunky appearance ?

Again thank you so much for the feedback ! \<3

---

<div class="post-metadata">

**Author:** ![InferNova](https://yyz2.discourse-cdn.com/flex036/user_avatar/discourse.processing.org/infernova/32/6009_2.png) [@InferNova](https://discourse.processing.org/u/InferNova)\
**Post date:** [June 26, 2019, 10:44pm UTC](https://discourse.processing.org/t/hiscapes-roast-my-game/12082/8 "2019-06-26T22:44:41Z")

</div>

UPDATE: The game finishing intentions is getting a huge redo ! This was supposed to be an open world hack-n-slash… But I have decided to make it into a medieval survive waves game ! I will be redoing my server class to allow up to 4 player to be present at once ! And swapping out the tiles as random generation will not need to apply anymore !